feat: ability to init ts files with WerfRenderContext type#593
Merged
feat: ability to init ts files with WerfRenderContext type#593
Conversation
Signed-off-by: Dmitry Mordvinov <dmitry.mordvinov@flant.com>
Signed-off-by: Dmitry Mordvinov <dmitry.mordvinov@flant.com>
ilya-lesikov
requested changes
Apr 13, 2026
pkg/ts/init.go
Outdated
|
|
||
| const denoBuildScript = "deno bundle --output=dist/bundle.js src/index.ts" | ||
| const ( | ||
| defaultRenderContextType = "RenderContext" |
Member
There was a problem hiding this comment.
Move it where WerfRenderContextType is defined and name it something like TSGenericRenderContextType and TSWerfRenderContextType. Then add a TSDefaultRenderContextType = TSGenericRenderContextType
pkg/ts/init_templates.go
Outdated
| } | ||
| ` | ||
| deploymentTSContent = `import type { RenderContext } from '@nelm/chart-ts-sdk'; | ||
| deploymentTSTmpl = `import type { {{RenderContextType}} } from '@nelm/chart-ts-sdk'; |
Member
There was a problem hiding this comment.
well, since we started templating it, then let's do it properly via go text/template engine. Just init a new blank engine and pass a context ($) into it with all you need. Will be easier to extend later. And the template will become this instead: {{ $.RenderContextType }}
Signed-off-by: Dmitry Mordvinov <dmitry.mordvinov@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.